Enable Docker build checks #872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://docs.docker.com/build/checks/ A Docker build will now fail if there is a violation against one of the built-in Docker validation rules
NickLarsenNZ
requested changes
Sep 19, 2024
There was a problem hiding this comment.
Needs a changelog entry.
I also asked elsewhere but can't recall where.. what should we do about the hadolint failures around apt package versioning?
Non-admins won't be able to merge if the errors aren't resolved (I don't think).
We can either add a rule to ignore those checks (so it works as it always has), or pin the versions - which is a bit of work and will constantly need changing.
# Conflicts: # spark-k8s/Dockerfile
|
Changelog has been added as to your other question: the pre-commit checks are optional for now, I'd be happy to add a rule ignoring those packaging things for now until we get to it |
NickLarsenNZ
reviewed
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable Docker build checks
https://docs.docker.com/build/checks/
A Docker build will now fail if there is a violation against one of the built-in Docker validation rules
I did manually build all images and fixed all validation warnings that popped up. Most were not bad but two were an actual bug (spark & kafka-testing-tools, both not bad)
Definition of Done Checklist
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
baketo retrieve the image tag for<image-tagged-with-the-major-version>.